Adds wasmtime-c-api dependency to support WASM scripts/functions #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new dependency on the `wasmtime-c-api` library. https://github.com/bytecodealliance/wasmtime Wasmtime is a standalone runtime for WebAssembly (aka WASM), and we will use it to run WASM binaries inside the Valkey engine. To enable WASM support in Valkey we need to build Valkey with: ``` make BUILD_WITH_WASM=yes ``` If you have your own `wasmtime-c-api` local build, you can specify its location so that our build system can pick it up: ``` make BUILD_WITH_WASM=yes WASMTIME_ROOT=path ``` If you just want to use the upstream `wasmtime-c-api` binary, you can run: ``` make download-wasm-binary-deps ``` before building valkey to download the upstream binary. Signed-off-by: Ricardo Dias <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1183 +/- ##
============================================
- Coverage 70.66% 70.66% -0.01%
============================================
Files 114 114
Lines 61716 61799 +83
============================================
+ Hits 43611 43668 +57
- Misses 18105 18131 +26 |
zuiderkwast
reviewed
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new dependency on the
wasmtime-c-apilibrary.https://github.com/bytecodealliance/wasmtime
Wasmtime is a standalone runtime for WebAssembly (aka WASM), and we will use it to run WASM binaries inside the Valkey engine.
To enable WASM support in Valkey we need to build Valkey with:
If you have your own
wasmtime-c-apilocal build, you can specify its location so that our build system can pick it up:If you just want to use the upstream
wasmtime-c-apibinary, you can run:before building valkey to download the upstream binary.